netdev - Re: [net-next v2 28/71] 8139*/atp/r8169/sc92031: Move the Realtek drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312256485.2294.3.camel@jtkirshe-mobl>
Date:	Mon, 01 Aug 2011 20:41:07 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jeff Garzik <jgarzik@...ox.com>
Cc:	Ben Hutchings <bhutchings@...arflare.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	Realtek linux nic maintainers <nic_swsd@...ltek.com>,
	Francois Romieu <romieu@...zoreil.com>,
	Donald Becker <becker@...ld.com>
Subject: Re: [net-next v2 28/71] 8139*/atp/r8169/sc92031: Move the Realtek
 drivers

On Mon, 2011-08-01 at 20:21 -0700, Jeff Garzik wrote:
> On 08/01/2011 08:24 PM, Ben Hutchings wrote:
> > On Sat, 2011-07-30 at 20:26 -0700, Jeff Kirsher wrote:
> >> Move the Realtek drivers into drivers/net/ethernet/realtek/ and make
> >> the necessary Kconfig and Makefile changes.
> > [...]
> >
> > Does it really make sense to move the pci-skeleton driver?  Although it
> > includes hardware access specific to RTL8139 chips, that's not really
> > the point of it.
> 
> Indeed.  pci-skeleton was simply intended to illustrate a clean driver 
> for a simple DMA-driven NIC.
> 
> Honestly, it's so outdated now that deletion would be a better course.

If it would be useful, should we take the time to update pci-skeleton
driver?  Or will this be a maintenance issue going forward and deletion
is the best answer?

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)