netdev - Re: [PATCH ] cdc_ncm: fixes for big-endian architecture / MIPS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1108021544360.2158-100000@iolanthe.rowland.org>
Date:	Tue, 2 Aug 2011 15:45:34 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Oliver Neukum <oliver@...kum.org>
cc:	Alexey Orishko <alexey.orishko@...il.com>,
	<netdev@...r.kernel.org>, <davem@...emloft.net>,
	<linux-usb@...r.kernel.org>, <gregkh@...e.de>,
	Alexey Orishko <alexey.orishko@...ricsson.com>
Subject: Re: [PATCH ] cdc_ncm: fixes for big-endian architecture / MIPS

On Tue, 2 Aug 2011, Oliver Neukum wrote:

> Am Dienstag, 2. August 2011, 18:20:26 schrieb Alexey Orishko:
> > Changes:
> > - removed redandunt conversion for usb control requests
> > - added missing conversion for nth16.wNdpIndex
> > Thanks to Giuseppe Scrivano for providing fixes
> 
> What? How can a conversion of endianness be redundant?

When it's done twice.  :-)

> Either this version or the old version must be buggy. What is
> happening here?

The old version is buggy.  Read the code and you'll see.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html