netdev - Re: [net-next v2 56/71] macb: Move the Atmel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1312362216.2294.139.camel@jtkirshe-mobl>
Date:	Wed, 03 Aug 2011 02:03:35 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	Jamie Iles <jamie@...ieiles.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next v2 56/71] macb: Move the Atmel driver

On Wed, 2011-08-03 at 01:50 -0700, Nicolas Ferre wrote:
> On 08/03/2011 09:47 AM, Jamie Iles wrote:
> > On Tue, Aug 02, 2011 at 10:59:28PM -0700, Jeff Kirsher wrote:
> >> On Mon, 2011-08-01 at 07:49 -0700, Nicolas Ferre wrote:
> >>> On 07/31/2011 04:27 AM, Jeff Kirsher wrote:
> >>>> Move the Atmel driver into drivers/net/ethernet/cadence/ and
> >>>> make the necessary Kconfig and Makefile changes.
> >>>>
> >>>> CC: Nicolas Ferre<nicolas.ferre@...el.com>
> >>>
> >>> You can add my:
> >>> Acked-by: Nicolas Ferre<nicolas.ferre@...el.com>
> >>>
> >>>> CC: Jamie Iles<jamie@...ieiles.com>
> >>>> Signed-off-by: Jeff Kirsher<jeffrey.t.kirsher@...el.com>
> >>
> >> Nicolas/Jamie-
> >>
> >> I have a v3 series of patches coming out here imminently, and I have
> >> tweaked the Kconfig just a bit based on feedback from others.  Since the
> >> "tweak" made sense for all the Kconfig, I applied it across the board.
> >> Here is the new Kconfig:
> > [...]
> >> If these changes are fine, I can add your ACK's.
> >
> > It all reads fine to me though I wonder if we should substitute Atmel
> > for Cadence.  Perhaps this should be a separate patch though that makes
> > it a little clearer in the drivers too.

Not that I am trying to get out of the additional cleanup, but I vote
for a separate patch after we go through the push of this series of
patches. :)

> 
> Yes, that is true.
> 
> > Anyhow, for now I'm happy as it is, so:
> >
> > Acked-by: Jamie Iles<jamie@...ieiles.com>
> 
> Yes, you can add my:
> 
> Acked-by: Nicolas Ferre <nicolas.ferre@...el.com>

Thanks, I will add your ACK's.

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)