netdev - Re: [RFC 4/4] [powerpc] Implement a p1010rdb clock source.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <39414D86-7822-4B92-B005-351890A2A167@kernel.crashing.org>
Date:	Sat, 6 Aug 2011 11:52:45 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	Robin Holt <holt@....com>, Wolfgang Grandegger <wg@...ndegger.com>,
	U Bhaskar-B22300 <B22300@...escale.com>,
	socketcan-core@...ts.berlios.de, Netdev <netdev@...r.kernel.org>,
	"linuxppc-dev@...ts.ozlabs.org Development" 
	<linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [RFC 4/4] [powerpc] Implement a p1010rdb clock source.


On Aug 6, 2011, at 8:58 AM, Marc Kleine-Budde wrote:

> On 08/06/2011 06:05 AM, Robin Holt wrote:
>> flexcan driver needs the clk_get, clk_get_rate, etc functions
>> to work.  This patch provides the minimum functionality.
> 
> This patch has to go via the powerpc git tree. Added
> linuxppc-dev@...ts.ozlabs.org on CC.
> 
>> Signed-off-by: Robin Holt <holt@....com>
>> To: Marc Kleine-Budde <mkl@...gutronix.de>
>> To: Wolfgang Grandegger <wg@...ndegger.com>
>> To: U Bhaskar-B22300 <B22300@...escale.com>
>> Cc: socketcan-core@...ts.berlios.de
>> Cc: netdev@...r.kernel.org
>> ---
>> arch/powerpc/platforms/85xx/p1010rdb.c |   78 ++++++++++++++++++++++++++++++++
>> 1 files changed, 78 insertions(+), 0 deletions(-)

NAK.

This doesn't look right at all.  We should be doing something based on the device tree node that isn't board specific.

I believe Bhaskar has a version of flexcan support that he's been working on cleanup up for upstream.

- k--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html