netdev - Re: [PATCH] net_sched: prio: use qdisc_dequeue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110809134532.GA28510@Chamillionaire.breakpoint.cc>
Date:	Tue, 9 Aug 2011 15:45:32 +0200
From:	Florian Westphal <fw@...len.de>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Florian Westphal <fw@...len.de>, netdev@...r.kernel.org
Subject: Re: [PATCH] net_sched: prio: use qdisc_dequeue_peeked

Eric Dumazet <eric.dumazet@...il.com> wrote:
> >  Eric, does this look correct to you?
> >  I am not sure if sfq needs fixing instead of this patch here.
> > 
> > diff --git a/net/sched/sch_prio.c b/net/sched/sch_prio.c
> > index 2a318f2..b5d56a2 100644
> > --- a/net/sched/sch_prio.c
> > +++ b/net/sched/sch_prio.c
> > @@ -112,7 +112,7 @@ static struct sk_buff *prio_dequeue(struct Qdisc *sch)
> >  
> >  	for (prio = 0; prio < q->bands; prio++) {
> >  		struct Qdisc *qdisc = q->queues[prio];
> > -		struct sk_buff *skb = qdisc->dequeue(qdisc);
> > +		struct sk_buff *skb = qdisc_dequeue_peeked(qdisc);
> >  		if (skb) {
> >  			qdisc_bstats_update(sch, skb);
> >  			sch->q.qlen--;
> 
> 
> Hi Florian
> 
> Are you sure this patch is still needed, after commit 
> e1738bd9cecc5c867b0e2996470c1ff20f66ba79
> (sch_sfq: fix sfq_enqueue())

Yes, I double checked.  This patch is applied, also
I see HFSC complaints even without that code path touched by
"sch_sfq: fix sfq_enqueue" being hit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html