lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Aug 2011 19:59:34 +0200 From: Eric Dumazet <eric.dumazet@...il.com> To: Joe Perches <joe@...ches.com> Cc: stufever@...il.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, davem@...emloft.net, Wang Shaoyan <wangshaoyan.pt@...bao.com> Subject: Re: [PATCH] gianfar: reduce stack usage in gianfar_ethtool.c Le mardi 09 août 2011 à 10:52 -0700, Joe Perches a écrit : > On Tue, 2011-08-09 at 18:53 +0200, Eric Dumazet wrote: > > Le mercredi 10 août 2011 à 00:39 +0800, stufever@...il.com a écrit : > [] > > > + if (!local_rqfpr || !local_rqfcr) { > > > + pr_err("Out of memory\n"); > > Please remove this pr_err(), kmalloc() will complain already. > > Always? > I know there's a trace option, but is it always on? > Yes, unless caller added ___GFP_NOWARN in gfp : ptr = kmalloc(size, GFP_KERNEL | ___GFP_NOWARN); -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists