netdev - Re: [PATCH] ipv4: Fix ip_getsockopt for IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110809082404.GA24845@mail.gmail.com>
Date:	Tue, 9 Aug 2011 02:24:04 -0600
From:	Jean Sacren <sakiwit@...il.com>
To:	Daniel Baluta <dbaluta@...acom.com>
Cc:	"David S. Miller" <davem@...emloft.net>, tszocs@...acom.com,
	Linux Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH] ipv4: Fix ip_getsockopt for IP_PKTOPTIONS

From: Daniel Baluta <dbaluta@...acom.com>
Date: Sun, 07 Aug 2011 02:20:50 +0300
>
> IP_PKTOPTIONS is broken for 32-bit applications running
> in COMPAT mode on 64-bit kernels.
> 
> This happens because msghdr's msg_flags field is always
> set to zero. When running in COMPAT mode this should be
> set to MSG_CMSG_COMPAT instead.
> 
> Signed-off-by: Tiberiu Szocs-Mihai <tszocs@...acom.com>
> Signed-off-by: Daniel Baluta <dbaluta@...acom.com>
> ---
>  net/ipv4/ip_sockglue.c |    9 +++++----
>  1 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
> index ab0c9ef..c77f5a8 100644
> --- a/net/ipv4/ip_sockglue.c
> +++ b/net/ipv4/ip_sockglue.c
> @@ -1067,7 +1067,7 @@ EXPORT_SYMBOL(compat_ip_setsockopt);
>   */
>  
>  static int do_ip_getsockopt(struct sock *sk, int level, int optname,
> -			    char __user *optval, int __user *optlen)
> +			    char __user *optval, int __user *optlen, unsigned flags)
>  {
>  	struct inet_sock *inet = inet_sk(sk);
>  	int val;
> @@ -1240,7 +1240,7 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname,
>  
>  		msg.msg_control = optval;
>  		msg.msg_controllen = len;
> -		msg.msg_flags = 0;
> +		msg.msg_flags = flags;
>  
>  		if (inet->cmsg_flags & IP_CMSG_PKTINFO) {
>  			struct in_pktinfo info;
> @@ -1294,7 +1294,7 @@ int ip_getsockopt(struct sock *sk, int level,
>  {
>  	int err;
>  
> -	err = do_ip_getsockopt(sk, level, optname, optval, optlen);
> +	err = do_ip_getsockopt(sk, level, optname, optval, optlen, 0);
>  #ifdef CONFIG_NETFILTER
>  	/* we need to exclude all possible ENOPROTOOPTs except default case */
>  	if (err == -ENOPROTOOPT && optname != IP_PKTOPTIONS &&
> @@ -1327,7 +1327,8 @@ int compat_ip_getsockopt(struct sock *sk, int level, int optname,
>  		return compat_mc_getsockopt(sk, level, optname, optval, optlen,
>  			ip_getsockopt);
>  
> -	err = do_ip_getsockopt(sk, level, optname, optval, optlen);
> +	err = do_ip_getsockopt(sk, level, optname, optval, optlen, 
> +		MSG_CMSG_COMPAT);
>  
>  #ifdef CONFIG_NETFILTER
>  	/* we need to exclude all possible ENOPROTOOPTs except default case */
> -- 
> 1.7.2.5

I think the original patch can be simplified. Feedback is greatly
appreciated.

diff --git a/net/ipv4/ip_sockglue.c b/net/ipv4/ip_sockglue.c
index ab0c9ef..f6eed68 100644
--- a/net/ipv4/ip_sockglue.c
+++ b/net/ipv4/ip_sockglue.c
@@ -1240,7 +1240,7 @@ static int do_ip_getsockopt(struct sock *sk, int level, int optname,
 
 		msg.msg_control = optval;
 		msg.msg_controllen = len;
-		msg.msg_flags = 0;
+		msg.msg_flags = MSG_CMSG_COMPAT;
 
 		if (inet->cmsg_flags & IP_CMSG_PKTINFO) {
 			struct in_pktinfo info;

-- 
Jean Sacren
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html