netdev - Re: [PATCH] net: fix potential neighbour race in dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 09 Aug 2011 21:47:50 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	synapse@...py.csoma.elte.hu, netdev@...r.kernel.org
Subject: Re: [PATCH] net: fix potential neighbour race in dst_ifdown()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Tue, 09 Aug 2011 08:56:14 +0200

> Le mercredi 03 août 2011 à 03:34 -0700, David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Sat, 30 Jul 2011 07:00:53 +0200
>> 
>> > [PATCH] net: fix NULL dereferences in check_peer_redir()
>> 
>> I'm adding this now to my tree so it gets more widespread
>> testing.
> 
> Thanks David
> 
> We probably have other races, here is a followup patch, probably suited
> for net-next, since its not clear if its a real problem while device is
> unregistering. Consider it as a cleanup at very least.
> 
> [PATCH] net: fix potential neighbour race in dst_ifdown()
> 
> Followup of commit f2c31e32b378a (fix NULL dereferences in
> check_peer_redir()).
> 
> We need to make sure dst neighbour doesnt change in dst_ifdown().
> 
> Fix some sparse errors.
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Ok, applied.  I'll keep working to eliminate dst->_neighbour entirely
as that's a better long term solution I think :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html