netdev - Re: [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1BE7ECA1-8E3D-4750-9DC7-0FABC1B6E545@kernel.crashing.org>
Date:	Thu, 11 Aug 2011 12:40:03 -0500
From:	Kumar Gala <galak@...nel.crashing.org>
To:	Marc Kleine-Budde <mkl@...gutronix.de>
Cc:	Robin Holt <holt@....com>, Wolfgang Grandegger <wg@...ndegger.com>,
	U Bhaskar-B22300 <B22300@...escale.com>,
	Scott Wood <scottwood@...escale.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	socketcan-core@...ts.berlios.de, netdev@...r.kernel.org,
	PPC list <linuxppc-dev@...ts.ozlabs.org>,
	devicetree-discuss@...ts.ozlabs.org
Subject: Re: [PATCH v11 5/6] flexcan: Prefer device tree clock frequency if available.


On Aug 11, 2011, at 11:18 AM, Marc Kleine-Budde wrote:

> On 08/11/2011 06:07 PM, Robin Holt wrote:
>> If our CAN device's device tree node has a clock-frequency property,
>> then use that value for the can devices clock frequency.  If not, fall
>> back to asking the platform/mach code for the clock frequency associated
>> with the flexcan device.
> 
> nitpicking follows inline:
> 
>> Signed-off-by: Robin Holt <holt@....com>
>> To: Kumar Gala <galak@...nel.crashing.org>
>> To: Wolfgang Grandegger <wg@...ndegger.com>,
>> To: Marc Kleine-Budde <mkl@...gutronix.de>,
>> To: U Bhaskar-B22300 <B22300@...escale.com>
>> To: Scott Wood <scottwood@...escale.com>
>> To: Grant Likely <grant.likely@...retlab.ca>
>> Cc: socketcan-core@...ts.berlios.de,
>> Cc: netdev@...r.kernel.org,
>> Cc: PPC list <linuxppc-dev@...ts.ozlabs.org>
>> Cc: devicetree-discuss@...ts.ozlabs.org
>> ---
>> .../devicetree/bindings/net/can/fsl-flexcan.txt    |    2 +
>> drivers/net/can/flexcan.c                          |   33 +++++++++++++++-----
>> 2 files changed, 27 insertions(+), 8 deletions(-)
>> 
>> diff --git a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>> index c78dcbb..a4382c7 100644
>> --- a/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>> +++ b/Documentation/devicetree/bindings/net/can/fsl-flexcan.txt
>> @@ -11,6 +11,7 @@ Required properties:
>> 
>> - reg : Offset and length of the register set for this device
>> - interrupts : Interrupt tuple for this device
>> +- clock-frequency : The oscillator frequency driving the flexcan device
>> 
>> Example:
>> 
>> @@ -19,4 +20,5 @@ Example:
>>           reg = <0x1c000 0x1000>;
>>           interrupts = <48 0x2>;
>>           interrupt-parent = <&mpic>;
>> +          clock-frequency = <0x0bebc1fc>;
> 
> Does the device tree support dec coded integers? IMHO a frequency is
> best expressed in decimal.

Yes it does, and agree that in the example a dec # might be better

- k--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html