netdev - Re: [PATCH] net: sh_irda: fixup build error on v3.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110810.231558.2202030270747790994.davem@davemloft.net>
Date:	Wed, 10 Aug 2011 23:15:58 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	kuninori.morimoto.gx@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: sh_irda: fixup build error on v3.1

From: Kuninori Morimoto <kuninori.morimoto.gx@...il.com>
Date: Wed, 10 Aug 2011 22:49:01 -0700 (PDT)

> @@ -171,7 +173,7 @@ static void sh_irda_write(struct sh_irda_self *self, u32 offset, u16 data)
>  	unsigned long flags;
>  
>  	spin_lock_irqsave(&self->lock, flags);
> -	iowrite16(data, self->membase + offset);
> +	__raw_writew(data, self->membase + offset);
>  	spin_unlock_irqrestore(&self->lock, flags);

Every platform, including "sh", provides ioread16() and iowrite16().

So changing this is not part of "fixup build error" as your commit
message states.

If this change is needed, it should be in a seperate commit and with
a proper explanation in the commit message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html