netdev - Re: [net-next 10/10] i825xx: Move the Intel 82586/82593/82596 based drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1313060697.6733.111.camel@phil-desktop>
Date:	Thu, 11 Aug 2011 12:04:55 +0100
From:	Phil Blundell <philb@....org>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, netdev@...r.kernel.org, gospo@...dhat.com,
	sassmann@...hat.com, Russell King <linux@....linux.org.uk>,
	aris@...hedrallabs.org, Donald Becker <becker@...ld.com>,
	Chris Beauregard <cpbeaure@...ergrad.math.uwaterloo.ca>,
	Richard Procter <rnp@...adise.net.nz>,
	Andries Brouwer <aeb@....nl>,
	"M.Hipp" <hippm@...ormatik.uni-tuebingen.de>,
	Richard Hirst <richard@...epie.demon.co.uk>,
	Sam Creasey <sammy@...verio.com>,
	Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Subject: Re: [net-next 10/10] i825xx: Move the Intel 82586/82593/82596 based
 drivers

On Wed, 2011-08-10 at 20:27 -0700, Jeff Kirsher wrote:
> Move the drivers that use the i82586/i82593/i82596 chipsets into
> drivers/net/ethernet/i825xx/ and make the necessary Kconfig and
> Makefile changes.  There were 4 3Com drivers which were initially
> moved into 3com/, which now reside in i825xx since they all used
> the i82586 chip.

Actually, I think 3c505 was better in 3com/ where you had it before.
Although the card does use an i82586, it's front-ended by an 80186
microcontroller and that's what the driver talks to.  So there is no
meaningful code commonality with the other '586 drivers.

That said, I don't think it's a massive deal either way and if you have
a strong preference for putting it in i825xx then that's probably fine.

p.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html