netdev - Re: [Bugme-new] [Bug 39372] New: Problems with HFSC Scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <344feff5.16ac6e1d.4e3aa4c3.49362@o2.pl>
Date:	Thu, 04 Aug 2011 15:55:15 +0200
From:	Michal Pokrywka <wolfmoon@...pl>
To:	eric.dumazet@...il.com
Cc:	kaber@...sh.net, soltys@....info, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, bugme-daemon@...zilla.kernel.org,
	hadi@...erus.ca, lucas.bocchi@...il.com, 631945@...s.debian.org,
	00bormoj@...il.com, fdelawarde@...elessmundi.com
Subject: Re: [Bugme-new] [Bug 39372] New: Problems with HFSC Scheduler

From: Michal Soltys <soltys@....info>
Date: Fri, 29 Jul 2011 14:29:10 +0200

>> On 11-07-22 11:58, Michal Pokrywka wrote:
>> 
>> commit b262a5da755cc6ed0cb4fba230cd9bf4037e1096 sch_sfq: fix peek()
>> implementation
>> 
>> and
>> 
>> commit 9df49f2bfe862573911a080c75a6d81113c5c81d sch_sfq: avoid giving
>> spurious NET_XMIT_CN signals
>> 
>> Reverting these patches makes HFSC work again.
>> 
>
> This one (upstream 8efa885406359af300d46910642b50ca82c0fe47) seems to be
> the culprit (does reverting only that one cures the problem ?)

Yes, indeed. Commit b262a5da755cc6ed0cb4fba230cd9bf4037e1096 is irrelevant.

Patch "sch_sfq: fix sfq_enqueue()" (provided by Eric Dumazet) applied to 2.6.39.1 fixes the problem, and hfsc+sfq works as expected.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html