netdev - Re: [PATCH 2/3] drivers/staging/rtl8192e: Don't pass huge struct by value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E45B684.6080300@lwfinger.net>
Date:	Fri, 12 Aug 2011 18:25:56 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	Jesper Juhl <jj@...osbits.net>
CC:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, Mike McCormack <mikem@...g3k.org>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	Stefan Weil <weil@...l.berlios.de>,
	Andrea Merello <andreamrl@...cali.it>, netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] drivers/staging/rtl8192e: Don't pass huge struct
 by value

On 08/12/2011 06:04 PM, Jesper Juhl wrote:
> From: Jesper Juhl<jj@...osbits.net>
> Date: Sat, 13 Aug 2011 00:52:32 +0200
>
> struct ieee80211_network is fairly large (more than half a kilobyte),
> so let's pass a pointer instead of passing the entire structure by
> value when ieee80211_is_54g() and ieee80211_is_shortslot() need to
> look at a few members.
> Also remove parentheses around the values being returned from those
> two functions - 'return' is not a function.
>
> Signed-off-by: Jesper Juhl<jj@...osbits.net>
> ---
>   drivers/staging/rtl8192e/ieee80211/ieee80211.h     |    4 ++--
>   .../staging/rtl8192e/ieee80211/ieee80211_softmac.c |   14 +++++++-------
>   2 files changed, 9 insertions(+), 9 deletions(-)

This patch is a good one; however, in Greg's pile of unmerged patches is a 
completely different driver for the RTL8192E. The new driver has the advantage 
of being organized much more like the drivers in rtlwifi. That will make it 
easier to convert to mac80211 and move to mainline.

I also have a lot of unsubmitted patches to clean up the code in the new driver. 
At the moment, it is clear of 'checkpatch -f' errors, and most warnings. In 
addition, many of the sparse warnings are fixed. Once Greg merges the patches 
already submitted, I will send the others.

Larry

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html