netdev - Re: [PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge struct by value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110813180531.34a47d9bf4851f8c1e9a227c@canb.auug.org.au>
Date:	Sat, 13 Aug 2011 18:05:31 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org,
	Andrea Merello <andreamrl@...cali.it>,
	Andre Nogueira <andre.neo.net@...il.com>,
	Lucas De Marchi <lucas.demarchi@...fusion.mobi>,
	"David S. Miller" <davem@...emloft.net>,
	Larry Finger <Larry.Finger@...inger.net>,
	Stefan Weil <weil@...l.berlios.de>,
	Ilia Mirkin <imirkin@...m.mit.edu>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/3] drivers/staging/rtl8187se: Don't pass huge struct
 by value

Hi all,

On Sat, 13 Aug 2011 01:04:36 +0200 (CEST) Jesper Juhl <jj@...osbits.net> wrote:
>
> From: Jesper Juhl <jj@...osbits.net>
> Date: Sat, 13 Aug 2011 00:51:40 +0200
> 
> struct ieee80211_network is fairly large (more than half a kilobyte),
> so let's pass a pointer instead of passing the entire structure by
> value when ieee80211_is_54g() and ieee80211_is_shortslot() need to
> look at a few members.
> Also remove parentheses around the values being returned from those
> two functions - 'return' is not a function.

Also, is there some reason that they are not "static inline bool"
functions defined directlt in ieee80211.h?

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped