lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Aug 2011 15:45:08 +0300 From: "Eilon Greenstein" <eilong@...adcom.com> To: "Michal Schmidt" <mschmidt@...hat.com> cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Dmitry Kravkov" <dmitry@...adcom.com>, "Vladislav Zolotarov" <vladz@...adcom.com> Subject: Re: [PATCH] bnx2x: suppress repeated error messages about Max BW On Tue, 2011-08-16 at 04:38 -0700, Michal Schmidt wrote: > On 08/15/2011 08:47 PM, Eilon Greenstein wrote: > > On Mon, 2011-08-15 at 08:13 -0700, Michal Schmidt wrote: > >> A tester reported getting only these 4 messages with the patch applied: > >> > >> [bnx2x_extract_max_cfg:1074(eth4)]Illegal configuration detected for Max > >> BW on vn 2 - using 100 instead > >> [bnx2x_extract_max_cfg:1074(eth5)]Illegal configuration detected for Max > >> BW on vn 2 - using 100 instead > >> [bnx2x_extract_max_cfg:1074(eth6)]Illegal configuration detected for Max > >> BW on vn 3 - using 100 instead > >> [bnx2x_extract_max_cfg:1074(eth7)]Illegal configuration detected for Max > >> BW on vn 3 - using 100 instead > >> > >> This suggests that VNs 0 and 1 had non-zero Max BW configuration. > > > > Michal - this is a great point of data! It helped me finding a bug in > > that code - the code is not suitable for 4 port devices, it always > > assumes 4 VN per PCI function, while in 4 port devices there are only 2 > > VN per PCI function. I assume that you are seeing this problem on a > > 57800 with 2x10G + 2x1G - and the 1G devices are in single function mode > > and therefore you are seeing this error message. I will send a patch to > > fix the problem on 4 port devices soon (after testing it for a while) - > > please confirm that you are seeing this issue on 2x10G+2x1G 57800 > > device. > > Eilon, > the tester is seeing this with BCM57711E. It's a HP-Blade bl460c-g6 with > HP VirtualConnect. Quote from him: > > hp-agents reports 4 dual port nic's, Linux kernel reports 8 identical > nic's but it's actual a blade with 2 LOM's (lan on motherboard) with > each one port. Via VC we present max 4 FlexNic's per port, but for > this server we present 2 FlexNic's per port. > > The fun with Linux is that it always sees all FlexNic's devices even > if we configure 2 FlexNics via a VC profile on a port like on this > server. > > Michal I see. This seems to be a valid VC configuration and therefore the message should be reduced to debug level all together. At least we resolved a 4 port configuration problem... Eilon -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists