netdev - Re: [patch net-next-2.6 2/3] net: remove use of ndo_set_multicast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110816200744.GA1971@minipsycho>
Date:	Tue, 16 Aug 2011 22:07:45 +0200
From:	Jiri Pirko <jpirko@...hat.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net,
	shemminger@...ux-foundation.org, eric.dumazet@...il.com,
	kaber@...sh.net, yoshfuji@...ux-ipv6.org, rdunlap@...otime.net,
	kuznet@....inr.ac.ru, jmorris@...ei.org, mirqus@...il.com,
	jesse@...ira.com
Subject: Re: [patch net-next-2.6 2/3] net: remove use of
 ndo_set_multicast_list in drivers

Tue, Aug 16, 2011 at 08:40:28PM CEST, bhutchings@...arflare.com wrote:
>On Tue, 2011-08-16 at 18:29 +0200, Jiri Pirko wrote:
>> replace it by ndo_set_rx_mode
>[...]
>
>Shouldn't this also rename the implementations whose names include
>'multicast'?

I was thinking about that. But sometimes it's not absolutelly trivial.
Also, I think that perserving the existing names would cause any
troubles so I left that as it is. Feel free to do incremental patch :)

>
>Ben.
>
>-- 
>Ben Hutchings, Staff Engineer, Solarflare
>Not speaking for my employer; that's the marketing department's job.
>They asked us to note that Solarflare product names are trademarked.
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html