netdev - Re: [PATCH] ipv6: Fix ipv6_getsockopt for IPV6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZBDXdgKqQJGymB13g_F73wY764cgvSL40tB=1GDmMto4g@mail.gmail.com>
Date:	Fri, 19 Aug 2011 14:23:22 +0300
From:	Daniel Baluta <dbaluta@...acom.com>
To:	David Miller <davem@...emloft.net>
Cc:	kuznet@....inr.ac.ru, jmorris@...ei.org, kaber@...sh.net,
	netdev@...r.kernel.org, sdumitru@...acom.com
Subject: Re: [PATCH] ipv6: Fix ipv6_getsockopt for IPV6_2292PKTOPTIONS

On Fri, Aug 19, 2011 at 1:19 PM, David Miller <davem@...emloft.net> wrote:
> From: Daniel Baluta <dbaluta@...acom.com>
> Date: Fri, 19 Aug 2011 12:55:58 +0300
>
>> IPV6_2292PKTOPTIONS is broken for 32-bit applications running
>> in COMPAT mode on 64-bit kernels.
>>
>> The same problem was fixed for IPv4 with the patch:
>> ipv4: Fix ip_getsockopt for IP_PKTOPTIONS,
>> commit dd23198e58cd35259dd09e8892bbdb90f1d57748
>>
>> Signed-off-by: Sorin Dumitru <sdumitru@...acom.com>
>> Signed-off-by: Daniel Baluta <dbaluta@...acom.com>
>
> Applied, but:
>
>> -     err = do_ipv6_getsockopt(sk, level, optname, optval, optlen);
>> +     err = do_ipv6_getsockopt(sk, level, optname, optval, optlen,
>
> This adds trailing whitespace, which GIT catches and warns about,
> please be mindful of this in the future.
>
> I took care of it and fixed it up this time.

Thanks David. I will pay more attention to this next time.

Daniel.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html