netdev - RE: [net-next 04/12] bna: TX Path and RX Path Changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 23 Aug 2011 11:06:41 -0700
From:	Rasesh Mody <rmody@...cade.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Adapter Linux Open SRC Team" 
	<adapter_linux_open_src_team@...cade.COM>,
	Gurunatha Karaje <gkaraje@...cade.com>
Subject: RE: [net-next 04/12] bna: TX Path and RX Path Changes

>From: David Miller [mailto:davem@...emloft.net]
>Sent: Monday, August 22, 2011 4:46 PM
>
>From: Rasesh Mody <rmody@...cade.com>
>Date: Mon, 22 Aug 2011 15:41:01 -0700
>
>> +		if (unlikely(skb_is_gso(skb) > netdev->mtu)) {
>
>skb_is_gso() is mean to be a boolean test, it happens to return
>the value of ->gso_size as it's implementation but that's not
>a good reason for you to abuse this interface in this way.
>
>If we every fix skb_is_gso() to return a true 'bool' your driver
>will break.
>
>Access ->gso_size directly if that's what you're interested in,
>that way it's future proof and won't break in the future.

Hi Dave,
We've addressed this by accessing ->gso_size directly and resubmitted
the patch-set.
Thanks for the suggestion,
--Rasesh

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html