netdev - RE: [patch -next] bna: unlock on error path in pnad_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <E5313AF6F2BFD14293E5FD0F94750F86A9E4B8C4DE@HQ1-EXCH01.corp.brocade.com>
Date:	Wed, 24 Aug 2011 10:25:45 -0700
From:	Rasesh Mody <rmody@...cade.com>
To:	Dan Carpenter <error27@...il.com>
CC:	Debashis Dutt <ddutt@...cade.com>,
	"open list:BROCADE BNA 10 GI..." <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	Jing Huang <huangj@...cade.COM>
Subject: RE: [patch -next] bna: unlock on error path in pnad_pci_probe()

>From: Dan Carpenter [mailto:error27@...il.com]
>Sent: Wednesday, August 24, 2011 4:29 AM
>
>We introduced a new lock here, so there was error path which needs
>an unlock now.
>
>Signed-off-by: Dan Carpenter <error27@...il.com>
>
>diff --git a/drivers/net/ethernet/brocade/bna/bnad.c
>b/drivers/net/ethernet/brocade/bna/bnad.c
>index bdfda07..6ad4b47 100644
>--- a/drivers/net/ethernet/brocade/bna/bnad.c
>+++ b/drivers/net/ethernet/brocade/bna/bnad.c
>@@ -3167,7 +3167,7 @@ bnad_pci_probe(struct pci_dev *pdev,
> 	 */
> 	err = bnad_pci_init(bnad, pdev, &using_dac);
> 	if (err)
>-		goto free_netdev;
>+		goto unlock_mutex;
>
> 	/*
> 	 * Initialize bnad structure
>@@ -3296,9 +3296,9 @@ drv_uninit:
> 	bnad_uninit(bnad);
> pci_uninit:
> 	bnad_pci_uninit(pdev);
>+unlock_mutex:
> 	mutex_unlock(&bnad->conf_mutex);
> 	bnad_lock_uninit(bnad);
>-free_netdev:
> 	free_netdev(netdev);
> 	return err;
> }

Acked-by: Rasesh Mody <rmody@...cade.com>

Thanks,
Rasesh
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html