netdev - Re: [PATCH net-next v5 1/2] af-packet: Added TPACKET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110824.194308.2024908890526228700.davem@davemloft.net>
Date:	Wed, 24 Aug 2011 19:43:08 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	loke.chetan@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next v5 1/2] af-packet: Added TPACKET_V3 headers.

From: Chetan Loke <loke.chetan@...il.com>
Date: Fri, 19 Aug 2011 16:18:15 -0400

> Added TPACKET_V3 definitions.
> 
> Signed-off-by: Chetan Loke <loke.chetan@...il.com>

Applied.

I would suggest, as a follow-up patch, we add some appropriate
prefixes to these new datastructures added to if_packet.h as
these are exposed to userspace.

For example "hdr_v1", "bd_ts", "bd_header_u", and "block_desc" are
just asking for namespace conflicts with something other API in
userspace or the user's own datastructures.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html