netdev - Re: [PATCH] stmmac: remove the STBus bridge setting from the GMAC code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4E56016A.8060709@st.com>
Date:	Thu, 25 Aug 2011 10:01:46 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	ML netdev <netdev@...r.kernel.org>,
	"David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH] stmmac: remove the STBus bridge setting from the GMAC
 code

Hello David
you can discard this because I'm resending it in a bundle of patches to
update the whole driver to the Aug_2011 version.

Peppe

On 8/22/2011 3:58 PM, Giuseppe CAVALLARO wrote:
> This patch removes a piece of code (actually commented)
> only useful for some ST platforms in the past.
> 
> This kind of setting now can be done by using the platform
> callbacks provided in linux/stmmac.h (see the stmmac.txt for
> further details).
> 
> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@...com>
> ---
>  drivers/net/stmmac/dwmac1000_core.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/stmmac/dwmac1000_core.c b/drivers/net/stmmac/dwmac1000_core.c
> index 0f63b3c..eea184a 100644
> --- a/drivers/net/stmmac/dwmac1000_core.c
> +++ b/drivers/net/stmmac/dwmac1000_core.c
> @@ -37,9 +37,6 @@ static void dwmac1000_core_init(void __iomem *ioaddr)
>  	value |= GMAC_CORE_INIT;
>  	writel(value, ioaddr + GMAC_CONTROL);
>  
> -	/* STBus Bridge Configuration */
> -	/*writel(0xc5608, ioaddr + 0x00007000);*/
> -
>  	/* Freeze MMC counters */
>  	writel(0x8, ioaddr + GMAC_MMC_CTRL);
>  	/* Mask GMAC interrupts */

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html