[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CAL3LdT6qO-H0BB0WBZKtxt+C1V5Z1vvfk0E6bpQm4iHQW8_JfA@mail.gmail.com>
Date: Sat, 27 Aug 2011 00:17:54 -0700
From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To: David Miller <davem@...emloft.net>
Cc: netdev@...r.kernel.org, gospo@...hat.com
Subject: Re: [net-next 00/10][pull request] Complete drivers/net/ move
On Wed, Aug 24, 2011 at 22:04, David Miller <davem@...emloft.net> wrote:
> From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> Date: Wed, 24 Aug 2011 21:50:25 -0700
>
>> The following are changes since commit 0856a304091b33a8e8f9f9c98e776f425af2b625:
>> Scm: Remove unnecessary pid & credential references in Unix socket's send and receive path
>> and are available in the git repository at:
>> master.kernel.org:/pub/scm/linux/kernel/git/jkirsher/next-organize master
>
> Still fails.
>
> Jeff, I'm not pulling any more, you're simply not testing this
> properly. You need to sit on this for a few days and start properly
> sanity checking what you're sending me. I should not get a broken
> build when I just type make on an "allmodconfig" tree right after
> I pull from you.
>
> Repeat, that should never happen, ever.
>
> It's not rocket science what I do to sanity test this.
>
> Take a vanilla net-next tree, "make allmodconfig" and build it.
>
> Pull your tree, "make oldconfig" and try to build it again, it fails.
>
> Why aren't you testing that? Because that's the first thing the rest
> of the world, especially everyone validating the -next tree, is going
> to do.
>
Dave I am sorry about the previous compile errors, I was not seeing
them when testing. You were correct, I was not using the allmodconfig
during my testing. Since then, I have found the solution to the
compile issue, and I have done several compile testing on the updated
patches (allmodconfig, allyesconfig, and several randconfig tests).
All looks fine. This issue was that ATM, IRDA, and several others
where needed PPP along with Serial Line Header Compression to get
compiled. While there were entries in drivers/net/Makefile for PPP
and SLIP, then would not call out the dependency directly. So I just
needed to add the Makefile options available in
drivers/net/ppp/Makefile and drivers/net/slip/ in
drivers/net/Makefile.
I am doing 2 more sanity compile checks before re-submitting this
patchset (for that last time). :)
--
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists