netdev - Re: [RFC PATCH] caif: Remove OOM messages, use kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110828.171628.554738440008982339.davem@davemloft.net>
Date:	Sun, 28 Aug 2011 17:16:28 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	joe@...ches.com
Cc:	akpm@...ux-foundation.org, sjur.brandeland@...ricsson.com,
	linux-kernel@...r.kernel.org, eric.dumazet@...il.com,
	netdev@...r.kernel.org
Subject: Re: [RFC PATCH] caif: Remove OOM messages, use kzalloc

From: Joe Perches <joe@...ches.com>
Date: Thu, 25 Aug 2011 16:22:24 -0700

> Remove per site OOM messages because they duplicate
> the generic mm subsystem OOM message.
> 
> Use kzalloc instead of kmalloc/memset
> when next to the OOM message removals.
> 
> Reduces object size (allyesconfig ~2%)
> 
> $ size -t drivers/net/caif/built-in.o.old net/caif/built-in.o.old
>    text	   data	    bss	    dec	    hex	filename
>   32297	    700	   8224	  41221	   a105	drivers/net/caif/built-in.o.old
>   72159	   1317	  20552	  94028	  16f4c	net/caif/built-in.o.old
>  104456	   2017	  28776	 135249	  21051	(TOTALS)
> $ size -t drivers/net/caif/built-in.o.new net/caif/built-in.o.new
>    text	   data	    bss	    dec	    hex	filename
>   31975	    700	   8184	  40859	   9f9b	drivers/net/caif/built-in.o.new
>   70748	   1317	  20152	  92217	  16839	net/caif/built-in.o.new
>  102723	   2017	  28336	 133076	  207d4	(TOTALS)
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Looks good to me, applied, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html