[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4E5B7F78.4030803@st.com>
Date:	Mon, 29 Aug 2011 14:00:56 +0200
From:	Giuseppe CAVALLARO <peppe.cavallaro@...com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 3/9] stmmac: add MMC supports exported via debugfs.
On 8/26/2011 6:12 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@...com>
> Date: Thu, 25 Aug 2011 10:00:23 +0200
> 
>> This patch adds the MMC management counters support.
>> MMC module is an extension of the register address
>> space and all the hardware counters can be accessed
>> via debugfs.
>> Below an example of the output:
> 
> This is not the appropriate way to expose internal chip counters.
> 
> Please use ethtool statistics for this.
Yes I'll do that and resend all the patches again.
Thanks for the review.
Peppe
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists