[<prev] [next>] [day] [month] [year] [list]
Message-Id: <201108290939.32243.thomas.jarosch@intra2net.com>
Date: Mon, 29 Aug 2011 09:39:32 +0200
From: Thomas Jarosch <thomas.jarosch@...ra2net.com>
To: netdev@...r.kernel.org
Subject: [PATCH] Always initialize fw_entry with NULL
Otherwise the exit code path might try to release
a non-existing firmware object on an error condition.
Issue detected by cppcheck.
Resending to netdev as orionco-devel seems to be sleeping.
Signed-off-by: Thomas Jarosch <thomas.jarosch@...ra2net.com>
---
drivers/net/wireless/orinoco/orinoco_usb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/orinoco/orinoco_usb.c
b/drivers/net/wireless/orinoco/orinoco_usb.c
index 811e87f..973a55f 100644
--- a/drivers/net/wireless/orinoco/orinoco_usb.c
+++ b/drivers/net/wireless/orinoco/orinoco_usb.c
@@ -1579,7 +1579,7 @@ static int ezusb_probe(struct usb_interface
*interface,
struct ezusb_priv *upriv = NULL;
struct usb_interface_descriptor *iface_desc;
struct usb_endpoint_descriptor *ep;
- const struct firmware *fw_entry;
+ const struct firmware *fw_entry = NULL;
int retval = 0;
int i;
--
1.7.4.4
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists