netdev - RE: [PATCH 19/24] sunrpc: Remove unnecessary OOM logging messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2E1EB2CF9ED1CB4AA966F0EB76EAB4430AEB4FAF@SACMVEXC2-PRD.hq.netapp.com>
Date:	Mon, 29 Aug 2011 16:25:08 -0700
From:	"Myklebust, Trond" <Trond.Myklebust@...app.com>
To:	"David Miller" <davem@...emloft.net>, <bharrosh@...asas.com>
Cc:	<joe@...ches.com>, <bfields@...ldses.org>, <neilb@...e.de>,
	<linux-nfs@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 19/24] sunrpc: Remove unnecessary OOM logging messages

> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Monday, August 29, 2011 6:04 PM
> To: bharrosh@...asas.com
> Cc: Myklebust, Trond; joe@...ches.com; bfields@...ldses.org;
> neilb@...e.de; linux-nfs@...r.kernel.org; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 19/24] sunrpc: Remove unnecessary OOM logging
> messages
> 
> From: Boaz Harrosh <bharrosh@...asas.com>
> Date: Mon, 29 Aug 2011 14:54:59 -0700
> 
> > I have a question about that. Are the dprints going to show the
stack
> backtrace?
> 
> Yes, OOMs give full stack backtraces.
> 
> > If yes above? then I'm not sure I like it either, because am I'll be
> getting a full
> > stack backtrace for every failed allocation?
> 
> They've been doing this for years, so obviously they haven't bothered
> you
> enough to care up to this point.
> 
> All of this pushback is pure uneducated noise, please stop blocking
> progress
> with poorly informed objections.

I can see that slub.c has the slab_out_of_memory() function that
(although ratelimited) warns you if the allocation failed. However I
can't find any equivalent for slab.c or slob.c.

Trond
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html