netdev - Re: [patch net-next-2.6 1/2] net: allow to change carrier via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110830112553.012ffa85@nehalam.ftrdhcpuser.net>
Date:	Tue, 30 Aug 2011 11:25:53 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Michał Mirosław <mirqus@...il.com>
Cc:	Jiri Pirko <jpirko@...hat.com>, netdev@...r.kernel.org,
	davem@...emloft.net, eric.dumazet@...il.com,
	bhutchings@...arflare.com
Subject: Re: [patch net-next-2.6 1/2] net: allow to change carrier via sysfs

On Tue, 30 Aug 2011 20:11:37 +0200
Michał Mirosław <mirqus@...il.com> wrote:

> 2011/8/30 Jiri Pirko <jpirko@...hat.com>:
> > Allow to write to "carrier" attribute. Devices may implement ndo_change_carrier
> > callback to allow changing carrier from userspace.
> 
> Do you expect drivers using implementation different than just calling
> netif_carrier_on/off? Or is it supposed to also e.g. power down PHYs?
> 
> BTW, I like this feature!

Ok for virtual devices, but please don't implement it in real hardware.
There is already enough breakage in carrier management in applications.
It also overlaps with operstate perhaps that is a more more complete
solution.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html