netdev - Re: [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E5E6F22.4060206@hartkopp.net>
Date:	Wed, 31 Aug 2011 19:28:02 +0200
From:	Oliver Hartkopp <socketcan@...tkopp.net>
To:	Rajan Aggarwal <rajan.aggarwal85@...il.com>
CC:	Urs Thuermann <urs.thuermann@...kswagen.de>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH 1/1] net/can/af_can.c: Change del_timer to del_timer_sync

On 31.08.2011 11:57, Rajan Aggarwal wrote:

> From: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@...il.com>
> 
> This is important for SMP platform to check if timer function is
> executing on other CPU with deleting the timer.
> 
> Signed-off-by: Rajan Aggarwal <Rajan Aggarwal rajan.aggarwal85@...il.com>
> ---


Acked-by: Oliver Hartkopp <socketcan@...tkopp.net>

Tnx Rajan.

>  net/can/af_can.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/can/af_can.c b/net/can/af_can.c
> index 8ce926d..9b0c32a 100644
> --- a/net/can/af_can.c
> +++ b/net/can/af_can.c
> @@ -857,7 +857,7 @@ static __exit void can_exit(void)
>  	struct net_device *dev;
>  
>  	if (stats_timer)
> -		del_timer(&can_stattimer);
> +		del_timer_sync(&can_stattimer);
>  
>  	can_remove_proc();
>  


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html