netdev - Re: [PATCH] ip route: don't implicitly filter address family

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110831104800.60f2afa9@nehalam.ftrdhcpuser.net>
Date:	Wed, 31 Aug 2011 10:48:00 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Dan McGee <dan@...hlinux.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] ip route: don't implicitly filter address family

On Fri, 15 Jul 2011 13:38:33 -0500
Dan McGee <dan@...hlinux.org> wrote:

> When looking at the output of 'ip route show' on an IPv6 capable
> machine, the default output doesn't show IPv6 routes. This is unlike any
> other ip subcommand, which show all address families by default.
> Furthermore, the behavior is totally bogus for different permutations of
> the command:
> 
>     ip route show : will show IPv4, not show IPv6
> 	ip route show table all : will show IPv4 and IPv6
> 	ip route -f link show : will show IPv4 and IPv6
> 
> Rectify this behavior by removing some 2004 code that tries to munge the
> address family if it is unspecified and fails bad at guessing the user's
> intention.
> 
> Signed-off-by: Dan McGee <dan@...hlinux.org>
> ---
>  ip/iproute.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/ip/iproute.c b/ip/iproute.c
> index ca09029..4458d9c 100644
> --- a/ip/iproute.c
> +++ b/ip/iproute.c
> @@ -1236,9 +1236,6 @@ static int iproute_list_flush_or_save(int argc, char **argv, int action)
>  		argc--; argv++;
>  	}
>  
> -	if (do_ipv6 == AF_UNSPEC && filter.tb)
> -		do_ipv6 = AF_INET;
> -
>  	ll_init_map(&rth);
>  
>  	if (id || od)  {

No, this will change the output for unsuspecting users and likely
break their scripts.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html