netdev - Re: [PATCH] iproute2: fix implicit declaration of function '__ALIGN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110831105904.256a4cec@nehalam.ftrdhcpuser.net>
Date:	Wed, 31 Aug 2011 10:59:04 -0700
From:	Stephen Hemminger <shemminger@...ux-foundation.org>
To:	Gilles Espinasse <g.esp@...e.fr>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] iproute2: fix implicit declaration of function
 '__ALIGN_KERNEL'

On Sun, 10 Jul 2011 17:46:20 +0200
Gilles Espinasse <g.esp@...e.fr> wrote:

> Warning seen with 2.6.32 kernel headers
>  m_xt.c:85: warning: implicit declaration of function '__ALIGN_KERNEL'
> 
> Declaration lines borrowed from iptables-1.4.11.1
> 
> Signed-off-by: Gilles Espinasse <g.esp@...e.fr>
> ---
>  include/linux/netfilter/x_tables.h |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/netfilter/x_tables.h b/include/linux/netfilter/x_tables.h
> index 4120970..a6614b0 100644
> --- a/include/linux/netfilter/x_tables.h
> +++ b/include/linux/netfilter/x_tables.h
> @@ -96,6 +96,8 @@ struct _xt_align {
>  	__u64 u64;
>  };
>  
> +#define __ALIGN_KERNEL(x, a)	__ALIGN_KERNEL_MASK(x, (typeof(x))(a) - 1)
> +#define __ALIGN_KERNEL_MASK(x, mask)	(((x) + (mask)) & ~(mask))
>  #define XT_ALIGN(s) __ALIGN_KERNEL((s), __alignof__(struct _xt_align))
>  
>  /* Standard return verdict, or do jump. */

This was a problem already fixed upstream by the iptables folks in later
version.  The files in include/linux are automatically generated by
a the kernel header script, and I don't want to start a bad precedent
by making a special case for this.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html