netdev - Re: [PATCH] iproute2: fix several warnings emitted by clang scan-build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110831122006.52c958dd@nehalam.ftrdhcpuser.net>
Date:	Wed, 31 Aug 2011 12:20:06 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Dan McGee <dan@...hlinux.org>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] iproute2: fix several warnings emitted by clang
 scan-build

On Fri, 15 Jul 2011 14:59:26 -0500
Dan McGee <dan@...hlinux.org> wrote:

> * genl/genl.c: remove unused basename logic, avoid dereference of
>   possibly NULL variable
> * ip/iptuntap.c: avoid double open and leak of file handle
> * misc/arpd.c: zero out socklen structure
> * misc/{ifstat,nstat,rtacct}.c: ensure uptime is initialized if
>   /proc/uptime cannot be opened
> * tc/m_xt.c: only unset fields if m is non-NULL
> 
> Signed-off-by: Dan McGee <dan@...hlinux.org>

All but arpd applied. The arpd change is unnecessary since the
socket structure is in recvfrom() call it will be set by kernel.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html