[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <89F823C255D94E19BB78C69C1996025C@realtek.com.tw>
Date: Thu, 1 Sep 2011 14:02:28 +0800
From: hayeswang <hayeswang@...ltek.com>
To: 'Francois Romieu' <romieu@...zoreil.com>
CC: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH net-next 1/3] r8169: fix WOL setting for 8105 and 8111EVL
> -----Original Message-----
> From: Francois Romieu [mailto:romieu@...zoreil.com]
> Sent: Thursday, September 01, 2011 3:14 AM
> To: Hayeswang
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH net-next 1/3] r8169: fix WOL setting for
> 8105 and 8111EVL
>
> Hayes Wang <hayeswang@...ltek.com> :
> > 8105, 8111E, and 8111EVL need enable RxConfig bit 1 ~ 3 for
> supporting
> > wake on lan.
> [...]
> > diff --git a/drivers/net/ethernet/realtek/r8169.c
> > b/drivers/net/ethernet/realtek/r8169.c
> > index 1cf8c3c..96e003a 100644
> > --- a/drivers/net/ethernet/realtek/r8169.c
> > +++ b/drivers/net/ethernet/realtek/r8169.c
> > @@ -3416,8 +3416,11 @@ static void
> r8168_pll_power_down(struct rtl8169_private *tp)
> > rtl_writephy(tp, 0x1f, 0x0000);
> > rtl_writephy(tp, MII_BMCR, 0x0000);
> >
> > - if (tp->mac_version == RTL_GIGA_MAC_VER_32 ||
> > - tp->mac_version == RTL_GIGA_MAC_VER_33)
> > + if (tp->mac_version == RTL_GIGA_MAC_VER_29 ||
> > + tp->mac_version == RTL_GIGA_MAC_VER_30 ||
> > + tp->mac_version == RTL_GIGA_MAC_VER_32 ||
> > + tp->mac_version == RTL_GIGA_MAC_VER_33 ||
> > + tp->mac_version == RTL_GIGA_MAC_VER_34)
> > RTL_W32(RxConfig, RTL_R32(RxConfig) |
> AcceptBroadcast |
> > AcceptMulticast | AcceptMyPhys);
>
> Fine for RTL_GIGA_MAC_VER_34 but RTL_GIGA_MAC_VER_29 and
> RTL_GIGA_MAC_VER_29 use r810x_pll_power_{up/down}, not their
> r8168_pll_xyz siblings.
>
I would fix it. Thanks.
Best Regards,
Hayes
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists