netdev - Re: [PATCH v2 -next] 6LoWPAN: fix skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEnQRZAYXs6DJrci=mBNWuNLiCJk3AuyGiTCqQoQFQN02eQdJQ@mail.gmail.com>
Date:	Thu, 1 Sep 2011 15:10:08 +0300
From:	Daniel Baluta <dbaluta@...acom.com>
To:	Alexander Smirnov <alex.bluesman.smirnov@...il.com>
Cc:	davem@...emloft.net, dbaryshkov@...il.com, slapin@...fans.org,
	linux-zigbee-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	eric.dumazet@...il.com, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2 -next] 6LoWPAN: fix skb_copy call

> +                       if (NULL == skb) {
> +                               stat = -ENOMEM;
> +                               break;
> +                       }

This can hurt our eyes :). I think the common convention
is to use: "if (skb == NULL) " or simply "if (!skb) "

thanks,
Daniel.