netdev - Re: [next] unix stream crashes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1315007703.2576.2965.camel@schen9-DESK>
Date:	Fri, 02 Sep 2011 16:55:03 -0700
From:	Tim Chen <tim.c.chen@...ux.intel.com>
To:	Valdis.Kletnieks@...edu
Cc:	Jiri Slaby <jirislaby@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	ML netdev <netdev@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Sedat Dilek <sedat.dilek@...glemail.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [next] unix stream crashes

On Fri, 2011-09-02 at 12:12 -0400, Valdis.Kletnieks@...edu wrote:
> On Thu, 01 Sep 2011 18:40:45 PDT, Tim Chen said:
> 
> > Yes, Jiri's log does indicate that something went wrong when releasing
> > the skb, most likely due to changes in the pid and credentials ref
> > count.  Unfortunately, I cannot duplicate the problem on my system.  Any
> > info on your system to help me debug will be appreciated.  I'll try to
> > take another look at the patch tomorrow.
> 
> Dell Latitude E6500, Core2 T8700 processor, x86_64 kernel, a slightly mangled
> Fedora Rawhide userspace.  I'd not be surprised if there's an idiocyncratic
> setting in my .config that makes the bug crawl out of the woodwork on my box,
> so I'm attaching the .config in case it provides some enlightenment.
> 
> If you want me to try a debugging or test patch, let me know...

Valdis,

I've tried your config on a few different machines but I'm still not
able to reproduce the problem.  Can you help me narrow things down?
Please revert my original patch.  I've separated my original changes
into two parts.  Try apply only the recv_scm.patch attached and try to
boot.  Then apply only the send_scm.patch without the rcv_scm.patch and
repeat.  Let me know which patch causes the boot problem.

I'll like to isolate the problem to either the send path or receive
path. My suspicion is the error handling portion of the send path is not
quite right but I haven't yet found any issues after reviewing the
patch.  

Thanks.

Tim

View attachment "scm_recv.patch" of type "text/x-patch" (1858 bytes)

View attachment "scm_send.patch" of type "text/x-patch" (3784 bytes)