netdev - Re: [patch net-next-2.6 v3] net: consolidate and fix ethtool_ops->get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1315057614.3092.160.camel@deadeye>
Date:	Sat, 03 Sep 2011 14:46:47 +0100
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jiri Pirko <jpirko@...hat.com>
Cc:	netdev@...r.kernel.org, ralf@...ux-mips.org, fubar@...ibm.com,
	andy@...yhouse.net, kaber@...sh.net, bprakash@...adcom.com,
	JBottomley@...allels.com, robert.w.love@...el.com,
	davem@...emloft.net, shemminger@...ux-foundation.org,
	decot@...gle.com, mirq-linux@...e.qmqm.pl,
	alexander.h.duyck@...el.com, amit.salecha@...gic.com,
	eric.dumazet@...il.com, therbert@...gle.com,
	paulmck@...ux.vnet.ibm.com, laijs@...fujitsu.com,
	xiaosuo@...il.com, greearb@...delatech.com, loke.chetan@...il.com,
	linux-mips@...ux-mips.org, linux-scsi@...r.kernel.org,
	devel@...n-fcoe.org, bridge@...ts.linux-foundation.org
Subject: Re: [patch net-next-2.6 v3] net: consolidate and fix
 ethtool_ops->get_settings calling

On Sat, 2011-09-03 at 15:34 +0200, Jiri Pirko wrote:
> This patch does several things:
> - introduces __ethtool_get_settings which is called from ethtool code and
>   from drivers as well. Put ASSERT_RTNL there.
> - dev_ethtool_get_settings() is replaced by __ethtool_get_settings()
> - changes calling in drivers so rtnl locking is respected. In
>   iboe_get_rate was previously ->get_settings() called unlocked. This
>   fixes it. Also prb_calc_retire_blk_tmo() in af_packet.c had the same
>   problem. Also fixed by calling __dev_get_by_index() instead of
>   dev_get_by_index() and holding rtnl_lock for both calls.
> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create()
>   so bnx2fc_if_create() and fcoe_if_create() are called locked as they
>   are from other places.
> - use __ethtool_get_settings() in bonding code
> 
> Signed-off-by: Jiri Pirko <jpirko@...hat.com>
Reviewed-by: Ben Hutchings <bhutchings@...arflare.com> [except FCoE bits]

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html