netdev - Re: 3.1-rc4: spectacular kernel errors / filesystem crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 13 Sep 2011 10:51:03 -0500
From:	Jon Mason <mason@...i.com>
To:	Justin Piszcz <jpiszcz@...idpixels.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	Jesse Brandeburg <jesse.brandeburg@...il.com>,
	Alan Piszcz <ap@...arrain.com>,
	NetDEV list <netdev@...r.kernel.org>, xfs@....sgi.com,
	linux-kernel@...r.kernel.org
Subject: Re: 3.1-rc4: spectacular kernel errors / filesystem crash

On Tue, Sep 13, 2011 at 10:42 AM, Justin Piszcz <jpiszcz@...idpixels.com> wrote:
>
>
> On Tue, 13 Sep 2011, Jon Mason wrote:
>
>> On Tue, Sep 13, 2011 at 9:54 AM, Justin Piszcz <jpiszcz@...idpixels.com>
>> wrote:
>>>
>>>
>>> On Tue, 13 Sep 2011, Eric Dumazet wrote:
>>>
>>>> Please Justin make sure you pulled commit
>>>> commit ed2888e906b56769b4ffabb9c577190438aa68b8
>>>> Author: Jon Mason <mason@...i.com>
>>>> Date:   Thu Sep 8 16:41:18 2011 -0500
>>>>
>>>>   PCI: Remove MRRS modification from MPS setting code
>>>>
>>>>   Modifying the Maximum Read Request Size to 0 (value of 128Bytes) has
>>>>   massive negative ramifications on some devices.  Without knowing which
>>>>   devices have this issue, do not modify from the default value when
>>>>   walking the PCI-E bus in pcie_bus_safe mode.  Also, make pcie_bus_safe
>>>>   the default procedure.
>>>>
>>>>   Tested-by: Sven Schnelle <svens@...ckframe.org>
>>>>   Tested-by: Simon Kirby <sim@...tway.ca>
>>>>   Tested-by: Stephen M. Cameron <scameron@...rdog.cce.hp.com>
>>>>   Reported-and-tested-by: Eric Dumazet <eric.dumazet@...il.com>
>>>>   Reported-and-tested-by: Niels Ole Salscheider
>>>> <niels_ole@...scheider-online.
>>>>   References: https://bugzilla.kernel.org/show_bug.cgi?id=42162
>>>>   Signed-off-by: Jon Mason <mason@...i.com>
>>>>   Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>
>>>>   Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
>>>
>>> Hello,
>>>
>>> I found this commit here:
>>> http://permalink.gmane.org/gmane.linux.kernel.pci/11700
>>
>> This is an early version of the patch.  This is the patch that you want:
>>
>> https://github.com/torvalds/linux/commit/ed2888e906b56769b4ffabb9c577190438aa68b8
>>
>> It appears that this patch didn't make it to lkml or linux-pci list
>> due to kernel.org DNS being down when it was sent.
>>
>> Thanks,
>> Jon
>
> I need to learn how to use git at some point, can you please provide plain
> text patches so I can apply them and reboot?
>
> Justin.

I've attached the 2 patches I asked Linus to include into 3.1-rc6.
Let me know if there are any issues.

Thanks,
Jon

View attachment "0001-Fix-pointer-dereference-before-call-to-pcie_bus_conf.patch" of type "text/x-patch" (2344 bytes)

View attachment "0002-PCI-Remove-MRRS-modification-from-MPS-setting-code.patch" of type "text/x-patch" (4404 bytes)