netdev - Re: [patch net-next-2.6] net: consolidate and fix ethtool_ops->get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20110915.173339.254712565622264560.davem@redhat.com>
Date:	Thu, 15 Sep 2011 17:33:39 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	jpirko@...hat.com
Cc:	netdev@...r.kernel.org, ralf@...ux-mips.org, fubar@...ibm.com,
	andy@...yhouse.net, kaber@...sh.net, bprakash@...adcom.com,
	JBottomley@...allels.com, robert.w.love@...el.com,
	shemminger@...ux-foundation.org, decot@...gle.com,
	bhutchings@...arflare.com, mirq-linux@...e.qmqm.pl,
	alexander.h.duyck@...el.com, amit.salecha@...gic.com,
	eric.dumazet@...il.com, therbert@...gle.com,
	paulmck@...ux.vnet.ibm.com, laijs@...fujitsu.com,
	xiaosuo@...il.com, greearb@...delatech.com, loke.chetan@...il.com,
	linux-mips@...ux-mips.org, linux-scsi@...r.kernel.org,
	devel@...n-fcoe.org, bridge@...ts.linux-foundation.org
Subject: Re: [patch net-next-2.6] net: consolidate and fix
 ethtool_ops->get_settings calling

From: Jiri Pirko <jpirko@...hat.com>
Date: Thu,  1 Sep 2011 21:28:24 +0200

> This patch does several things:
> - introduces __ethtool_get_settings which is called from ethtool code and
>   from dev_ethtool_get_settings() as well.
> - dev_ethtool_get_settings() becomes rtnl wrapper for
>   __ethtool_get_settings()
> - changes calling in drivers so rtnl locking is respected. In
>   iboe_get_rate was previously ->get_settings() called unlocked. This
>   fixes it
> - introduces rtnl_lock in bnx2fc_vport_create() and fcoe_vport_create()
>   so bnx2fc_if_create() and fcoe_if_create() are called locked as they
>   are from other places.
> - prb_calc_retire_blk_tmo() in af_packet.c was not calling get_settings
>   with rtnl_lock. So use dev_ethtool_get_settings here.
> - use __ethtool_get_settings() in bonding code
> 
> Signed-off-by: Jiri Pirko <jpirko@...hat.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html