netdev - Re: [PATCH 0/4] ibmveth fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110917065144.358da241@kryten>
Date:	Sat, 17 Sep 2011 06:51:44 +1000
From:	Anton Blanchard <anton@...ba.org>
To:	David Miller <davem@...emloft.net>
Cc:	santil@...ux.vnet.ibm.com, brking@...ux.vnet.ibm.com,
	rcj@...ux.vnet.ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH 0/4] ibmveth fixes

Hi Dave,

> All applied.

Thanks!

> I love those "ret1", "ret2", "ret3", "ret4" variables.
> 
> Each successive number in the names gives such incredible
> insight into the meaning and usage of the individual
> variables, making it painless for reviewers to understand
> this code.

:) That function needs to be simplified and rewritten, it took me a
while to get my head around it.

Anton
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html