lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Sep 2011 17:49:00 -0400 (EDT) From: David Miller <davem@...emloft.net> To: tore@....no Cc: netdev@...r.kernel.org Subject: Re: [PATCH] ipv6: Send ICMPv6 RSes only when RAs are accepted From: Tore Anderson <tore@....no> Date: Fri, 16 Sep 2011 23:43:01 +0200 > * David Miller > >> From: Tore Anderson <tore@....no> >> Date: Mon, 29 Aug 2011 14:08:33 +0200 >> >>> The change also makes "Hybrid Router" forwarding mode ("forwarding" >>> sysctl set to 2) redundant, as the only thing that distinguished it from >>> the standard Router mode (forwarding=1) was that RSes was being sent. It >>> has therefore been removed. >> >> You're not removing "accept_ra==2", it's still there in the test: >> >>> - if ((ifp->idev->cnf.forwarding == 0 || >>> - ifp->idev->cnf.forwarding == 2) && >>> + if (((ifp->idev->cnf.accept_ra == 1 && !ifp->idev->cnf.forwarding) || >>> + ifp->idev->cnf.accept_ra == 2) && >> >> And it does provide it's own unique behavior compared to >> "accept_ra==1". > > Hi David, > > I'm not removing accept_ra==2, no, only forwarding==2. Or, more > precisely, I'm only removing the *documentation* for forwarding==2; > forwarding==2 will still work, but there's no difference from > forwarding==1 any longer. Ok, please make this more clear in your commit message. Thank you. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists