[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20110917.004820.39754341376226194.davem@davemloft.net>
Date:	Sat, 17 Sep 2011 00:48:20 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	rmody@...cade.com
Cc:	netdev@...r.kernel.org, adapter_linux_open_src_team@...cade.com,
	gkaraje@...cade.com
Subject: Re: [net-next 3/3] bna: Eliminate Small Race Condition Window in
 RX Path
From: Rasesh Mody <rmody@...cade.com>
Date: Fri, 16 Sep 2011 18:06:48 -0700
> Change details:
>  - In a continuous sequence of ifconfig up/down operations, there is a small
>    window of race between bnad_set_rx_mode() and bnad_cleanup_rx() while the
>    former tries to access rx_info->rx & the latter sets it to NULL. This race
>    could lead to bna_rx_mode_set() being called with a NULL (rx_info->rx)
>    pointer and a crash.
>  - Hold bnad->bna_lock while setting / unsetting rx_info->rx in bnad_setup_rx()
>    & bnad_cleanup_rx(), thereby eliminating the race described above.
> 
> Signed-off-by: Gurunatha Karaje <gkaraje@...cade.com>
> Signed-off-by: Rasesh Mody <rmody@...cade.com>
Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists