netdev - Re: [GIT] Networking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1316375164.31335.18.camel@edumazet-laptop>
Date:	Sun, 18 Sep 2011 21:46:04 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Markus Trippelsdorf <markus@...ppelsdorf.de>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	David Miller <davem@...emloft.net>, akpm@...ux-foundation.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [GIT] Networking

Le dimanche 18 septembre 2011 à 21:23 +0200, Markus Trippelsdorf a
écrit :
> On 2011.09.18 at 11:06 -0700, Linus Torvalds wrote:
> > 2011/9/17 David Miller <davem@...emloft.net>:
> > >
> > > dpward (2):
> > >      net: Make flow cache namespace-aware
> > >      net: Handle different key sizes between address families in flow cache
> > >
> > > nhorman (1):
> > >      net: don't clear IFF_XMIT_DST_RELEASE in ether_setup
> > >
> > > rajan.aggarwal85@...il.com (1):
> > >      net/can/af_can.c: Change del_timer to del_timer_sync
> > 
> > Guys, if somebody has such a broken email setup that they don't even
> > show their own name, don't take patches from them.
> > 
> > If you cannot even set up email sanely, there is zero reason to
> > believe that the patch should be good. And if the patch is trivial and
> > you want to take it despite the source of the patch being crap, please
> > spend the five seconds to fix it up.
> > 
> > Proper names are part of the commit message. Don't make it look like
> > crap. I get ugly flashbacks to SVN or CVS when I see stuff like this.
> > Don't do it.
> 
> Plus commit 946cedccbd73874 breaks the build:
> 
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> net/built-in.o:sysctl_net.c:function tcp_v4_conn_request: error: undefined reference to 'cookie_v4_init_sequence'
> make: *** [.tmp_vmlinux1] Error 1
> 
> commit 946cedccbd7387488d2cee5da92cdfeb28d2e670
> Author: Eric Dumazet <eric.dumazet@...il.com>
> Date:   Tue Aug 30 03:21:44 2011 +0000
> 
>     tcp: Change possible SYN flooding messages
> 
>     "Possible SYN flooding on port xxxx " messages can fill logs on servers.
> 
>     Change logic to log the message only once per listener, and add two new
>     SNMP counters to track :
> 
>     TCPReqQFullDoCookies : number of times a SYNCOOKIE was replied to client
> 
>     TCPReqQFullDrop : number of times a SYN request was dropped because
>     syncookies were not enabled.
> 
>     Based on a prior patch from Tom Herbert, and suggestions from David.
> 
> 

Oh well, trying to remove those ugly #ifdef was not so easy.
I'll cook a patch, thanks for the report



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html