netdev - Re: [BUG?] tcp: potential bug in tcp_is_sackblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110918.210725.2061666096968958448.davem@davemloft.net>
Date:	Sun, 18 Sep 2011 21:07:25 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	zheng.z.yan@...el.com, netdev@...r.kernel.org,
	herbert@...dor.hengli.com.au, sfr@...b.auug.org.au
Subject: Re: [BUG?] tcp: potential bug in tcp_is_sackblock_valid()

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Sun, 18 Sep 2011 21:35:44 +0200

> Le vendredi 09 septembre 2011 à 09:45 +0800, Yan, Zheng a écrit :
>> Hi all,
>> 
>> I found a check in tcp_is_sackblock_valid() is suspicious. It against
>> its comment and RFC. I think the correct check should be:
>> 
>> ---
>> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
>> index 385c470..a5d01b1 100644
>> --- a/net/ipv4/tcp_input.c
>> +++ b/net/ipv4/tcp_input.c
>> @@ -1124,7 +1124,7 @@ static int tcp_is_sackblock_valid(struct tcp_sock *tp, int is_dsack,
>>                 return 0;
>>  
>>         /* ...Then it's D-SACK, and must reside below snd_una completely */
>> -       if (!after(end_seq, tp->snd_una))
>> +       if (after(end_seq, tp->snd_una))
>>                 return 0;
>>  
>>         if (!before(start_seq, tp->undo_marker))
>> ---
> 
> Acked-by: Eric Dumazet <eric.dumazet@...il.com>
> 
> This bug was introduced in 2.6.24 by commit 5b3c9882

Yan, please repost this patch with proper commit message and signoffs
so I can apply it, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html