netdev - Re: [PATCH] net: fix lockdep issue in __neigh_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHo-Oow0JfWyKmkB+rmY9D3GJvaAwVNuZzrdNA0vuQZ4=i+EGA@mail.gmail.com>
Date:	Mon, 19 Sep 2011 17:01:54 -0700
From:	Maciej Żenczykowski <zenczykowski@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	MuraliRaja Muniraju <muralira@...gle.com>
Subject: Re: [PATCH] net: fix lockdep issue in __neigh_event_send

> To my knowledge, no linux pristine linux kernel has this bug.
>
> dst_release() is lockless.

You are probably right there, I missed that this was caused by some
other old crappy code we've been trying to get rid of.

> So could you explain why its so important we add this 'bugfix' if it
> only applies to a Google kernel ?

Freeing the skb later seemed to be pretty painless...

> Anything I missed from my previous analysis ?
>
> Thanks !

Probably not.
Now that the dst cache is going away this probably doesn't really
matter either way.

Maciej
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html