netdev - Re: [PATCH] net: change capability used by socket options IP{,V6}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20110920.154213.888729603269720228.davem@redhat.com>
Date:	Tue, 20 Sep 2011 15:42:13 -0400 (EDT)
From:	David Miller <davem@...hat.com>
To:	bazsi@...abit.hu
Cc:	zenczykowski@...il.com, maze@...gle.com, netdev@...r.kernel.org
Subject: Re: [PATCH] net: change capability used by socket options
 IP{,V6}_TRANSPARENT

From: Balazs Scheidler <bazsi@...abit.hu>
Date: Tue, 13 Sep 2011 17:27:09 +0200

> On Fri, 2011-09-02 at 12:10 -0700, Maciej Żenczykowski wrote:
>> From: Maciej Żenczykowski <maze@...gle.com>
>> 
>> Up till now the IP{,V6}_TRANSPARENT socket options (which actually set
>> the same bit in the socket struct) have required CAP_NET_ADMIN
>> privileges to set or clear the option.
>> 
>> - we make clearing the bit not require any privileges.
>> - we deprecate using CAP_NET_ADMIN for this purpose.
>> - we introduce a new capability CAP_NET_TRANSPARENT,
>>   which is tailored to allow setting just this bit.
>> - we allow either one of CAP_NET_TRANSPARENT or CAP_NET_RAW
>>   to set this bit, because raw sockets already effectively
>>   allow you to emulate socket transparency, and make the
>>   transition easier for apps not desiring to use a brand
>>   new capability (because of header file or glibc support)
>> - we print a warning (but allow it) if you try to set
>>   the socket option with CAP_NET_ADMIN privs, but without
>>   either one of CAP_NET_TRANSPARENT or CAP_NET_RAW.
>> 
>> The reason for introducing a new capability is that while
>> transparent sockets are potentially dangerous (and can let you
>> spoof your source IP on traffic), they don't normally give you
>> the full 'freedom' of eavesdropping and/or spoofing that raw sockets
>> give you.
>> 
>> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
>> CC: Balazs Scheidler <bazsi@...abit.hu>
> 
> This is ok for me, as long as the security maintainers allow the
> introduction of this new cap.
> 
> Thanks for doing this and sorry for the late reply.
> 
> Acked-by: Balazs Scheidler <bazsi@...abit.hu>

I'm fine with this change too and I'll apply it as soon as at least
one security person ACK's the addition of the new capability bit.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html