netdev - [PATCH] macvtap: fix warning due to use of uninitialised var

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 20 Sep 2011 11:48:11 +0100
From:	Ian Campbell <ian.campbell@...rix.com>
To:	netdev@...r.kernel.org
CC:	Ian Campbell <ian.campbell@...rix.com>
Subject: [PATCH] macvtap: fix warning due to use of uninitialised var

d1b08284ade "macvtap: convert to SKB paged frag API." accidentally dropped the
initialisation of a variable leading to:
	drivers/net/macvtap.c:509:5: warning: ‘f’ may be used uninitialized
		in this function [-Wuninitialized]

Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
---
 drivers/net/macvtap.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/macvtap.c b/drivers/net/macvtap.c
index 7c3f84a..5beda89 100644
--- a/drivers/net/macvtap.c
+++ b/drivers/net/macvtap.c
@@ -503,6 +503,7 @@ static int zerocopy_sg_from_iovec(struct sk_buff *skb, const struct iovec *from,
 		skb->truesize += len;
 		atomic_add(len, &skb->sk->sk_wmem_alloc);
 		while (len) {
+			f = &skb_shinfo(skb)->frags[i];
 			__skb_fill_page_desc(
 				skb, i, page[i],
 				base & ~PAGE_MASK,
-- 
1.7.2.5

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html