netdev - [patch] usbnet: add timestamping support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110921121151.Horde.2_LlPML8999Oebhn0-QlTpA@webmail.df.eu>
Date:	Wed, 21 Sep 2011 12:11:51 +0200
From:	Michael Riesch <michael@...sch.at>
To:	netdev@...r.kernel.org
Cc:	davem@...emloft.net, Oliver Neukum <oneukum@...e.de>
Subject: [patch] usbnet: add timestamping support

In order to make USB-to-Ethernet-adapters (depending on usbnet) support
time stamping, the "skb_defer_rx_timestamp" and "skb_tx_timestamp"
function calls are added.

I considered to put these calls between #ifdef's to make them dependent
on CONFIG_NETWORK_PHY_TIMESTAMPING. I decided not to do so because except
the check whether the current packet is a PTP packet (and this check
should be fast) no overhead occurs. But let me know your opinion about
that one.

Looking forward to your comments,
Michael

Signed-off-by: Michael Riesch <michael@...sch.at>
---
  drivers/net/usb/usbnet.c |    6 ++++++
  1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index ce395fe..cdb9588 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -238,6 +238,10 @@ void usbnet_skb_return (struct usbnet *dev,  
struct sk_buff *skb)
          netif_dbg(dev, rx_status, dev->net, "< rx, len %zu, type 0x%x\n",
                    skb->len + sizeof (struct ethhdr), skb->protocol);
          memset (skb->cb, 0, sizeof (struct skb_data));
+
+        if (skb_defer_rx_timestamp(skb))
+                return;
+
          status = netif_rx (skb);
          if (status != NET_RX_SUCCESS)
                  netif_dbg(dev, rx_err, dev->net,
@@ -1053,6 +1057,8 @@ netdev_tx_t usbnet_start_xmit (struct sk_buff *skb,
          unsigned long                flags;
          int retval;

+        skb_tx_timestamp(skb);
+
          // some devices want funky USB-level framing, for
          // win32 driver (usually) and/or hardware quirks
          if (info->tx_fixup) {
-- 
1.7.0.4

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html