| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20110921.152117.752680402461232454.davem@davemloft.net> Date: Wed, 21 Sep 2011 15:21:17 -0400 (EDT) From: David Miller <davem@...emloft.net> To: herbert@...dor.hengli.com.au Cc: steffen.klassert@...unet.com, netdev@...r.kernel.org Subject: Re: [PATCH] xfrm: Perform a replay check after return from async codepaths From: Herbert Xu <herbert@...dor.hengli.com.au> Date: Wed, 21 Sep 2011 22:24:42 +1000 > On Wed, Sep 21, 2011 at 01:57:27PM +0200, Steffen Klassert wrote: >> >> Well, I've got pretty reproduceable crashes when the sender of >> the IPsec packets introduces reorder, that's why I noticed this. >> >> The problem is, that the replay check function is called before >> the asynchronous crypto processing and the replay advance function >> is called after resume from the asynchronous processing. So >> we can submit multiple packets to the crypto layer without >> updating the replay window. This means that the replay check >> function accepts packets that should have been dropped, because >> they are reordered and more than 'replay window size' packets >> to late. This leads to a crash as we try to update the replay >> window beyond the allocated bounds. > > OK I see what you mean now. > > Acked-by: Herbert Xu <herbert@...dor.apana.org.au> Applied, thanks everyone. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists