netdev - RE: [Pv-drivers] [PATCH 14/14] vmxnet3: convert to SKB paged frag API.

Open Source and information security mailing list archives

Message-ID: <B07832953588294D802727FF264E276A13EB817FE8@exch-mbx-112.vmware.com>
Date:	Thu, 22 Sep 2011 09:49:16 -0700
From:	Bhavesh Davda <bhavesh@...are.com>
To:	Ian Campbell <Ian.Campbell@...citrix.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"VMware, Inc." <pv-drivers@...are.com>
Subject: RE: [Pv-drivers] [PATCH 14/14] vmxnet3: convert to SKB paged frag
 API.

Okay.

Signed-off-by: Bhavesh Davda <bhavesh@...are.com>

- Bhavesh

Bhavesh P. Davda

> -----Original Message-----
> From: Ian Campbell [mailto:Ian.Campbell@...citrix.com]
> Sent: Thursday, September 22, 2011 9:47 AM
> To: Bhavesh Davda
> Cc: netdev@...r.kernel.org; VMware, Inc.
> Subject: RE: [Pv-drivers] [PATCH 14/14] vmxnet3: convert to SKB paged frag
> API.
> 
> On Thu, 2011-09-22 at 17:30 +0100, Bhavesh Davda wrote:
> > These changes look sane. What about frag->page_offset and frag->size, are
> there APIs to access those as well?
> 
> You can go at those directly.
> 
> The important part here is to abstract away the access to the ->page
> variable so we can change how the reference counting works.
> 
> So unless people think there is a compelling reason to hide away size
> and offset I wasn't planning on doing anything like that.
> 
> Ian.
> 
> >
> > [sorry can't pull from git.kernel.org at the moment to answer my own
> quesion]
> >
> > - Bhavesh
> >
> > Bhavesh P. Davda
> >
> > > -----Original Message-----
> > > From: pv-drivers-bounces@...are.com [mailto:pv-drivers-bounces@...are.com]
> On
> > > Behalf Of Ian Campbell
> > > Sent: Thursday, September 22, 2011 12:53 AM
> > > To: netdev@...r.kernel.org
> > > Cc: VMware, Inc.; Ian Campbell
> > > Subject: [Pv-drivers] [PATCH 14/14] vmxnet3: convert to SKB paged frag
> API.
> > >
> > > Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> > > Cc: Shreyas Bhatewara <sbhatewara@...are.com>
> > > Cc: "VMware, Inc." <pv-drivers@...are.com>
> > > Cc: netdev@...r.kernel.org
> > > ---
> > >  drivers/net/vmxnet3/vmxnet3_drv.c |    8 ++++----
> > >  1 files changed, 4 insertions(+), 4 deletions(-)
> > >
> > > diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c
> > > b/drivers/net/vmxnet3/vmxnet3_drv.c
> > > index 759c1a4..57e7c66 100644
> > > --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> > > +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> > > @@ -654,7 +654,7 @@ vmxnet3_append_frag(struct sk_buff *skb, struct
> > > Vmxnet3_RxCompDesc *rcd,
> > >
> > >  	BUG_ON(skb_shinfo(skb)->nr_frags >= MAX_SKB_FRAGS);
> > >
> > > -	frag->page = rbi->page;
> > > +	__skb_frag_set_page(frag, rbi->page);
> > >  	frag->page_offset = 0;
> > >  	frag->size = rcd->len;
> > >  	skb->data_len += frag->size;
> > > @@ -748,9 +748,9 @@ vmxnet3_map_pkt(struct sk_buff *skb, struct
> vmxnet3_tx_ctx
> > > *ctx,
> > >
> > >  		tbi = tq->buf_info + tq->tx_ring.next2fill;
> > >  		tbi->map_type = VMXNET3_MAP_PAGE;
> > > -		tbi->dma_addr = pci_map_page(adapter->pdev, frag->page,
> > > -					     frag->page_offset, frag->size,
> > > -					     PCI_DMA_TODEVICE);
> > > +		tbi->dma_addr = skb_frag_dma_map(&adapter->pdev->dev, frag,
> > > +						 0, frag->size,
> > > +						 PCI_DMA_TODEVICE);
> > >
> > >  		tbi->len = frag->size;
> > >
> > > --
> > > 1.7.2.5
> > >
> > > _______________________________________________
> > > Pv-drivers mailing list
> > > Pv-drivers@...are.com
> > > http://mailman2.vmware.com/mailman/listinfo/pv-drivers
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives