netdev - RE: [patch v2] caif: add error handling for allocation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <81C3A93C17462B4BBD7E272753C105791D2BC1882D@EXDCVYMBSTM005.EQ1STM.local>
Date:	Fri, 23 Sep 2011 12:38:45 +0200
From:	Sjur BRENDELAND <sjur.brandeland@...ricsson.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch v2] caif: add error handling for allocation

[Dan]: 
> The allocation of "phyinfo" wasn't checked, and also the allocation
> wasn't freed on error paths.  Sjur Brændeland pointed out as well
> that "phy_driver" should be freed on the error path too.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Looks good, thank you Dan.
Acked-by: Sjur Brændeland <sjur.brandeland@...ricsson.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html