netdev - Re: [net-next 05/10] if_link: Add additional parameter to IFLA_VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110925102238.55ba72eb@s6510.linuxnetplumber.net>
Date:	Sun, 25 Sep 2011 10:22:38 -0700
From:	Stephen Hemminger <shemminger@...tta.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	davem@...emloft.net, Greg Rose <gregory.v.rose@...el.com>,
	netdev@...r.kernel.org, gospo@...hat.com
Subject: Re: [net-next 05/10] if_link: Add additional parameter to
 IFLA_VF_INFO for spoof checking

On Sat, 24 Sep 2011 02:17:38 -0700
Jeff Kirsher <jeffrey.t.kirsher@...el.com> wrote:

> From: Greg Rose <gregory.v.rose@...el.com>
> 
> Add configuration setting for drivers to turn spoof checking on or off
> for discrete VFs.
> 
> Signed-off-by: Greg Rose <gregory.v.rose@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  include/linux/if_link.h   |    7 +++++++
>  include/linux/netdevice.h |    3 +++
>  net/core/rtnetlink.c      |   25 ++++++++++++++++++++++---
>  3 files changed, 32 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/if_link.h b/include/linux/if_link.h
> index 0ee969a..8bd6d6d 100644
> --- a/include/linux/if_link.h
> +++ b/include/linux/if_link.h
> @@ -279,6 +279,7 @@ enum {
>  	IFLA_VF_MAC,		/* Hardware queue specific attributes */
>  	IFLA_VF_VLAN,
>  	IFLA_VF_TX_RATE,	/* TX Bandwidth Allocation */
> +	IFLA_VF_SPOOFCHK,	/* Spoof Checking on/off switch */
>  	__IFLA_VF_MAX,
>  };
>  
> @@ -300,12 +301,18 @@ struct ifla_vf_tx_rate {
>  	__u32 rate; /* Max TX bandwidth in Mbps, 0 disables throttling */
>  };
>  
> +struct ifla_vf_spoofchk {
> +	__u32 vf;
> +	__u32 setting;
> +};
> +
>  struct ifla_vf_info {
>  	__u32 vf;
>  	__u8 mac[32];
>  	__u32 vlan;
>  	__u32 qos;
>  	__u32 tx_rate;
> +	__u32 spoofchk;
>  };

This breaks ABI compatibility, unless you add some special case code
to handle the case of tools sending the old ifla_vf_info. Users may have older version
of ip utilities that send smaller size structure.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html